Skip to content

Fix: CSS Styling when reopening file manager#2617

Merged
limetech merged 1 commit intounraid:masterfrom
Squidly271:Fix-Filemanager-CSS-Styling
Apr 22, 2026
Merged

Fix: CSS Styling when reopening file manager#2617
limetech merged 1 commit intounraid:masterfrom
Squidly271:Fix-Filemanager-CSS-Styling

Conversation

@Squidly271
Copy link
Copy Markdown
Contributor

@Squidly271 Squidly271 commented Apr 18, 2026 •
edited by coderabbitai Bot
Loading

Summary by CodeRabbit

  • Style
    • Refined styling for dialog boxes and UI widget components to enhance visual consistency, including updated border rendering and color appearance across interface elements.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 18, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: e2146ca8-984c-4105-a5a8-281b0500249b

📥 Commits

Reviewing files that changed from the base of the PR and between 7756908 and bc8b0ea.

📒 Files selected for processing (2)
  • emhttp/plugins/dynamix/sheets/BrowseButton.css
  • emhttp/plugins/dynamix/styles/default-dynamix.css

Walkthrough

CSS styling updates across two files apply !important flags to jQuery UI widget properties and dialog styling to ensure consistent visual presentation and override conflicting stylesheets.

Changes

Cohort / File(s) Summary
jQuery UI Component Styling
emhttp/plugins/dynamix/sheets/BrowseButton.css		 Updated .ui-dfm .ui-dialog-titlebar-close to force border: none via !important.
jQuery UI Widget & Dialog Styling
emhttp/plugins/dynamix/styles/default-dynamix.css		 Added !important flags to .ui-widget-header properties (border, background, color, font-weight). Added !important flags to .ui-widget-content properties (border, background, color). Introduced new rules for .ui-dialog .ui-dialog-buttonpane with top border and .ui-dialog .ui-dialog-content with border removal.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A CSS cascade so fine,
With !important marks in a line,
Borders now bold, dialogs styled right,
jQuery widgets gleaming bright,
This little bunny hops with delight! 🎨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix: CSS Styling when reopening file manager' is specific and directly related to the changes, which involve CSS styling updates in the file manager plugin to fix issues that occur when reopening the file manager.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 18, 2026

🔧 PR Test Plugin Available

A test plugin has been generated for this PR that includes the modified files.

Version: 2026.04.18.1834
Build: View Workflow Run

📥 Installation Instructions:

Install via Unraid Web UI:

  1. Go to Plugins → Install Plugin
  2. Copy and paste this URL:
https://preview.dl.unraid.net/pr-plugins/pr-2617/webgui-pr-2617.plg
  1. Click Install

Alternative: Direct Download

⚠️ Important Notes:

  • Testing only: This plugin is for testing PR changes
  • Backup included: Original files are automatically backed up
  • Easy removal: Files are restored when plugin is removed
  • Conflicts: Remove this plugin before installing production updates
  • Post-merge behavior: This preview stays available after merge until preview storage expires or it is manually cleaned up

📝 Modified Files:

Click to expand file list 
emhttp/plugins/dynamix/sheets/BrowseButton.css
emhttp/plugins/dynamix/styles/default-dynamix.css

🔄 To Remove:

Navigate to Plugins → Installed Plugins and remove webgui-pr-2617, or run:

plugin remove webgui-pr-2617

🤖 This comment is automatically generated and will be updated with each new push to this PR.

@Squidly271 Squidly271 added the 7.3 label Apr 18, 2026
elibosley
elibosley approved these changes Apr 20, 2026
View reviewed changes
Comment thread emhttp/plugins/dynamix/styles/default-dynamix.css
border: 1px solid var(--dynamix-jquery-ui-border-color);
background: var(--dynamix-jquery-ui-content-background);
color: var(--dynamix-jquery-ui-content-color);
border: 1px solid var(--dynamix-jquery-ui-border-color) !important;
Copy link
Copy Markdown
Member

@elibosley elibosley Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love adding !important to these classes, this could cause issues on other containers, why is the cascade wrong here?

@Squidly271
Copy link
Copy Markdown
Contributor Author

Squidly271 commented Apr 22, 2026

nvm @elibosley ZFS Master winds up reloading jquery-ui CSS which then puts it at the top of the cascade.

@limetech limetech merged commit f8e4427 into unraid:master Apr 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elibosley elibosley elibosley approved these changes

Assignees

No one assigned

Labels

7.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Squidly271 @elibosley @limetech